Fix errors (#407)

* Make sure that unit tests run on all release versions

* [ErgoDox EZ] Fix complication issues due to updates

* [ErgoDox EZ] Fix compilication errors and warnings

We want all green!

* Fix weird merge conflicts

.github/workflows/unit_test.yml

@@ -6,8 +6,7 @@ permissions:
 on:
   push:
     branches:
-    - master
+    - firmware[0-9]+
-    - develop
   pull_request:
     paths:
     - 'builddefs/**'

data/mappings/keyboard_aliases.hjson

@@ -37,5 +37,14 @@
     },
     "voyager": {
         "target": "zsa/voyager"
+    },
+    "zsa/ergodox_ez": {
+        "target": "zsa/ergodox_ez/m32u4/base"
+    },
+    "zsa/ergodox_ez/m32u4": {
+        "target": "zsa/ergodox_ez/m32u4/base"
+    },
+    "zsa/ergodox_ez/stm32": {
+        "target": "zsa/ergodox_ez/stm32/base"
     }
 }

keyboards/zsa/ergodox_ez/config.h

@@ -42,8 +42,6 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #define MOUSEKEY_WHEEL_MAX_SPEED MOUSEKEY_MAX_SPEED
 #define MOUSEKEY_WHEEL_TIME_TO_MAX MOUSEKEY_TIME_TO_MAX
 
-#define TAPPING_TOGGLE 1
-
 #define BOOTMAGIC_LITE_ROW_RIGHT 13
 #define BOOTMAGIC_LITE_COLUMN_RIGHT 0
 
@@ -83,12 +81,9 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 // RGB backlight
-#define DRIVER_ADDR_1 0b1110100
+#define IS31FL3731_I2C_ADDRESS_1 IS31FL3731_I2C_ADDRESS_GND
-#define DRIVER_ADDR_2 0b1110111
+#define IS31FL3731_I2C_ADDRESS_2 IS31FL3731_I2C_ADDRESS_VCC
-#define DRIVER_COUNT 2
+#define IS31FL3731_I2C_TIMEOUT 5
-#define DRIVER_1_LED_TOTAL 24
-#define DRIVER_2_LED_TOTAL 24
-#define RGB_MATRIX_LED_COUNT (DRIVER_1_LED_TOTAL + DRIVER_2_LED_TOTAL)
 
 #define RGB_MATRIX_LED_PROCESS_LIMIT 5
 #define RGB_MATRIX_LED_FLUSH_LIMIT 26

keyboards/zsa/ergodox_ez/ergodox_ez.c

@@ -196,7 +196,7 @@ const keypos_t PROGMEM hand_swap_config[MATRIX_ROWS][MATRIX_COLS] = {
 
 #ifdef RGB_MATRIX_ENABLE
 // clang-format off
-__attribute__((weak)) const is31_led PROGMEM g_is31_leds[RGB_MATRIX_LED_COUNT] = {
+__attribute__((weak)) const is31fl3731_led_t PROGMEM g_is31fl3731_leds[IS31FL3731_LED_COUNT] = {
 /*   driver
  *   |  R location
  *   |  |      G location

keyboards/zsa/ergodox_ez/m32u4/glow/keyboard.json

@@ -2,5 +2,8 @@
     "keyboard_name": "ErgoDox EZ Glow",
     "usb": {
         "pid": "0x4976"
+    },
+    "features": {
+        "rgb_matrix": true
     }
 }

keyboards/zsa/ergodox_ez/m32u4/glow/rules.mk

@@ -1 +0,0 @@
-RGB_MATRIX_ENABLE = yes

keyboards/zsa/ergodox_ez/m32u4/m32u4.c

@@ -53,7 +53,8 @@ void keyboard_post_init_sub(void) {
 }
 
 #ifdef RGB_MATRIX_ENABLE
-const is31_led PROGMEM g_is31_leds[RGB_MATRIX_LED_COUNT] = {
+const is31fl3731_led_t PROGMEM g_is31fl3731_leds[IS31FL3731_LED_COUNT] = {
+
 /*   driver
  *   |  R location
  *   |  |      G location

keyboards/zsa/ergodox_ez/m32u4/rules.mk

@@ -1 +0,0 @@
-DEFAULT_FOLDER = zsa/ergodox_ez/m32u4/base

keyboards/zsa/ergodox_ez/m32u4/shine/keyboard.json

@@ -2,5 +2,8 @@
     "keyboard_name": "ErgoDox EZ Shine",
     "usb": {
         "pid": "0x4975"
+    },
+    "features": {
+        "rgblight": true
     }
 }

keyboards/zsa/ergodox_ez/m32u4/shine/rules.mk

@@ -1 +0,0 @@
-RGBLIGHT_ENABLE = yes

keyboards/zsa/ergodox_ez/rules.mk

@@ -7,4 +7,3 @@ I2C_DRIVER_REQUIRED = yes
 
 MOUSE_SHARED_EP = no
 
-DEFAULT_FOLDER = zsa/ergodox_ez/m32u4/base

keyboards/zsa/ergodox_ez/stm32/rules.mk

@@ -1 +0,0 @@
-DEFAULT_FOLDER = zsa/ergodox_ez/stm32/base

tests/tap_hold_configurations/chordal_hold/default/config.h

@@ -1,9 +1,5 @@
-<<<<<<<< HEAD:tests/tap_hold_configurations/chordal_hold/default/config.h
 /* Copyright 2022 Vladislav Kucheriavykh
  * Copyright 2024 Google LLC
-========
-/* Copyright 2024 ThanhSon.Mech
->>>>>>>> origin/master:keyboards/trnthsn/e8ghty/halconf.h
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -21,11 +17,5 @@
 
 #pragma once
 
-<<<<<<<< HEAD:tests/tap_hold_configurations/chordal_hold/default/config.h
 #include "test_common.h"
 #define CHORDAL_HOLD
-========
-#define HAL_USE_SPI TRUE
-
-#include_next <halconf.h>
->>>>>>>> origin/master:keyboards/trnthsn/e8ghty/halconf.h

tests/tap_hold_configurations/chordal_hold/hold_on_other_key_press/config.h

@@ -1,9 +1,5 @@
-<<<<<<<< HEAD:tests/tap_hold_configurations/chordal_hold/hold_on_other_key_press/config.h
 /* Copyright 2022 Vladislav Kucheriavykh
  * Copyright 2024 Google LLC
-========
-/* Copyright 2022 QMK
->>>>>>>> origin/master:keyboards/deemen17/de80/halconf.h
  *
  * This program is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -21,13 +17,6 @@
 
 #pragma once
 
-<<<<<<<< HEAD:tests/tap_hold_configurations/chordal_hold/hold_on_other_key_press/config.h
 #include "test_common.h"
 #define CHORDAL_HOLD
 #define HOLD_ON_OTHER_KEY_PRESS
-========
-#define HAL_USE_SPI TRUE
-
-#include_next <halconf.h>
-
->>>>>>>> origin/master:keyboards/deemen17/de80/halconf.h

tests/tap_hold_configurations/chordal_hold/retro_shift_permissive_hold/config.h

@@ -19,11 +19,7 @@
 
 #include "test_common.h"
 
-<<<<<<<< HEAD:tests/tap_hold_configurations/chordal_hold/retro_shift_permissive_hold/config.h
 #define CHORDAL_HOLD
-========
-// place overrides here
->>>>>>>> origin/master:keyboards/unikeyboard/diverge3/keymaps/iso_uk/config.h
 #define PERMISSIVE_HOLD
 
 #define RETRO_SHIFT 2 * TAPPING_TERM