From 5f653afeafb50641a37284979b05301319f27102 Mon Sep 17 00:00:00 2001 From: Florian Didron Date: Mon, 30 Jun 2025 15:05:04 +0700 Subject: [PATCH 1/4] fix: use https over ssh for the qmk zsa modules --- .gitmodules | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitmodules b/.gitmodules index d0b9b65ae3..687ae9048a 100644 --- a/.gitmodules +++ b/.gitmodules @@ -27,4 +27,4 @@ branch = release/v8.2 [submodule "modules/zsa"] path = modules/zsa - url = git@github.com:zsa/qmk_modules.git + url = https://github.com/zsa/qmk_modules.git From 25eb1701ed3148e574761b105d840c569b677fa4 Mon Sep 17 00:00:00 2001 From: Florian Didron Date: Mon, 7 Jul 2025 16:03:22 +0700 Subject: [PATCH 2/4] h/f: moonlander dynamic macro end bug --- keyboards/zsa/moonlander/moonlander.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/keyboards/zsa/moonlander/moonlander.c b/keyboards/zsa/moonlander/moonlander.c index 926c88d998..df800eb799 100644 --- a/keyboards/zsa/moonlander/moonlander.c +++ b/keyboards/zsa/moonlander/moonlander.c @@ -81,9 +81,8 @@ bool dynamic_macro_record_end_kb(int8_t direction) { if (cancel_deferred_exec(dynamic_macro_token)) { dynamic_macro_token = INVALID_DEFERRED_TOKEN; STATUS_LED_3(false); - (false); } - return false; + return true; } # endif From 23706e8136869094b00b386cb8e0ade58c66ef43 Mon Sep 17 00:00:00 2001 From: Florian Didron Date: Mon, 7 Jul 2025 16:10:38 +0700 Subject: [PATCH 3/4] h/f: ergodox dynamic macro user hooks wrong signature --- keyboards/zsa/ergodox_ez/ergodox_ez.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/keyboards/zsa/ergodox_ez/ergodox_ez.c b/keyboards/zsa/ergodox_ez/ergodox_ez.c index 830a028aea..dd71656af1 100644 --- a/keyboards/zsa/ergodox_ez/ergodox_ez.c +++ b/keyboards/zsa/ergodox_ez/ergodox_ez.c @@ -312,15 +312,19 @@ void eeconfig_init_kb(void) { // EEPROM is getting reset! static bool is_dynamic_recording = false; static uint16_t dynamic_loop_timer; -void dynamic_macro_record_start_user(int8_t direction) { +bool dynamic_macro_record_start_user(int8_t direction) { is_dynamic_recording = true; dynamic_loop_timer = timer_read(); ergodox_right_led_1_on(); + + return true; } -void dynamic_macro_record_end_user(int8_t direction) { +bool dynamic_macro_record_end_user(int8_t direction) { is_dynamic_recording = false; layer_state_set_user(layer_state); + + return true; } #endif From 19ac56d311d65c1cd1014019e845ed42ef0da1aa Mon Sep 17 00:00:00 2001 From: Florian Didron Date: Thu, 10 Jul 2025 08:55:52 +0700 Subject: [PATCH 4/4] h/f: persist layer color toggle state in eeprom --- keyboards/zsa/voyager/voyager.c | 1 + 1 file changed, 1 insertion(+) diff --git a/keyboards/zsa/voyager/voyager.c b/keyboards/zsa/voyager/voyager.c index 433cfe1ef2..5a1698ffec 100644 --- a/keyboards/zsa/voyager/voyager.c +++ b/keyboards/zsa/voyager/voyager.c @@ -256,6 +256,7 @@ bool process_record_kb(uint16_t keycode, keyrecord_t *record) { if (record->event.pressed) { keyboard_config.disable_layer_led ^= 1; if (keyboard_config.disable_layer_led) rgb_matrix_set_color_all(0, 0, 0); + eeconfig_update_kb(keyboard_config.raw); } break; case RGB_TOG: